Moti Asayag has posted comments on this change. Change subject: engine: Remove network attachments for network interface ......................................................................
Patch Set 11: > Why do you need it, isn't changing FOREIGN KEY (nic_id) REFERENCES > vds_interface(id) ON DELETE SET NULL to ON DELETE CASCADE enough? I can't remember exactly the use cases for this method - perhaps searching for its usages will provide an answer for this question (i.e. I'd like to remove the network attachments while the nic still exist in the system). In addition, relying on db constraints will break compensation to properly work. -- To view, visit https://gerrit.ovirt.org/34071 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64e2432eceabea56466815db95e01e32ab7ea4fb Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
