Shubhendu Tripathi has posted comments on this change. Change subject: engine: Query to get list of cluster with nodes ......................................................................
Patch Set 3: (4 comments) https://gerrit.ovirt.org/#/c/40396/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllVdsGroupsHavingHostsQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllVdsGroupsHavingHostsQuery.java: Line 9: } Line 10: Line 11: @Override Line 12: protected void executeQueryCommand() { Line 13: setReturnValue(getDbFacade().getVdsGroupDao().getClustersHavingHosts()); > can be replaced with injection Done Line 14: } https://gerrit.ovirt.org/#/c/40396/3/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsGroupDAOTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsGroupDAOTest.java: Line 485: vdsGroups > rename to clusters Done Line 483: @Test Line 484: public void testGetClustersHavingHosts() { Line 485: List<VDSGroup> vdsGroups = ((VdsGroupDAODbFacadeImpl) dao).getClustersHavingHosts(); Line 486: assertNotNull(vdsGroups); Line 487: assertEquals(4, vdsGroups.size()); > you can use: Done Line 488: } https://gerrit.ovirt.org/#/c/40396/3/packaging/dbscripts/vds_groups_sp.sql File packaging/dbscripts/vds_groups_sp.sql: Line 262: GetVdsGroupsHavingHosts > s/GetVdsGroupsHavingHosts/GetClustersHavingHosts Done -- To view, visit https://gerrit.ovirt.org/40396 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c06388ec88436518ce2e8bd3855d64ba66400b7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
