Sahina Bose has posted comments on this change. Change subject: webadmin: Add new alerts required for RHSC Dashboard ......................................................................
Patch Set 1: (5 comments) https://gerrit.ovirt.org/#/c/40566/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java: Line 1008: correct formatting. you can compare if (fetchedStatus == GlusterStatus.DOWN) Line 1013: GlusterConstants brickQualifiedName returns <hostname or ipaddress>:<brick path>. Was this the intention here? https://gerrit.ovirt.org/#/c/40566/1/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/gluster/GlusterAuditLogUtil.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/gluster/GlusterAuditLogUtil.java: Line 70: final change to customValues as last parameter https://gerrit.ovirt.org/#/c/40566/1/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AuditLogDAO.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AuditLogDAO.java: Line 104: rename to removeAllofTypeForBrick ? https://gerrit.ovirt.org/#/c/40566/1/packaging/dbscripts/upgrade/03_06_1360_add_brickPath_audit_log_table.sql File packaging/dbscripts/upgrade/03_06_1360_add_brickPath_audit_log_table.sql: Line 2: ALTER can this be merged to a single statement? -- To view, visit https://gerrit.ovirt.org/40566 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibad5ed6078bd33cd9c9decdabca6747709be4ba4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Karnan t c <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
