Alona Kaplan has posted comments on this change. Change subject: engine: Re-define HostSetupNetworks based on network attachments ......................................................................
Patch Set 21: (3 comments) https://gerrit.ovirt.org/#/c/32910/21/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/HostNetwork.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/HostNetwork.java: Line 13: private boolean defaultRoute; Line 14: private boolean bonding; Line 15: Line 16: @SuppressWarnings("unused") Line 17: private HostNetwork() { The class is not Serializable, why do you need this ctor? Line 18: } Line 19: Line 20: public HostNetwork(Network network, NetworkAttachment networkAttachment) { Line 21: this.network = network; Line 99: } Line 100: Line 101: @Override Line 102: public String toString() { Line 103: StringBuilder builder = new StringBuilder(); Please use- ToStringBuilder Line 104: builder.append(getNetworkName()) Line 105: .append("{") Line 106: .append("nicName=") Line 107: .append(getNicName()) https://gerrit.ovirt.org/#/c/32910/21/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostSetupNetworksVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostSetupNetworksVDSCommand.java: Line 71: NetworkQosMapper qosMapper = Line 72: new NetworkQosMapper(attributes, Line 73: VdsProperties.HOST_QOS_INBOUND, Line 74: VdsProperties.HOST_QOS_OUTBOUND); Line 75: qosMapper.serialize(new NetworkQoS()); shouldn't you pass the network_qos or the overridden one in case they exist? Line 76: } Line 77: Line 78: networks.put(attachment.getNetworkName(), attributes); Line 79: } -- To view, visit https://gerrit.ovirt.org/32910 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75d02e4be71f00510bc8815c555a94d7efc9252e Gerrit-PatchSet: 21 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
