Piotr Kliczewski has posted comments on this change. Change subject: events: VM Status based on an event ......................................................................
Patch Set 11: (1 comment) https://gerrit.ovirt.org/#/c/37488/11/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/EventVMStatsRefresher.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/EventVMStatsRefresher.java: Line 63: Line 64: new VmsMonitoring(manager, changedVms, devicesChangedVms, auditLogDirector).perform(); Line 65: } finally { Line 66: subscription.request(1); Line 67: } > can't we get all pending events in one go? Or set some limit inside the inf We can set here a value of how many events we want to process. The code is written in that way that it will try to parallel the processing as much as possible. We are going to provide aggregation on vdsm side which should fix the issue of big number of events. This is not cpu but memory issue. Line 68: } Line 69: Line 70: private List<VmInternalData> convertEvent(Map<String, Object> map) { Line 71: List<VmInternalData> returnVMs = new ArrayList<VmInternalData>(); -- To view, visit https://gerrit.ovirt.org/37488 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5b35877ccd63372759ad6989280e9417c259b21 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
