Alona Kaplan has posted comments on this change.

Change subject: engine: Use more abstracted collection type.
......................................................................


Patch Set 21:

(2 comments)

https://gerrit.ovirt.org/#/c/33328/21/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Entities.java
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Entities.java:

Line 34:      *          }
Line 35:      *      }
Line 36:      * }
Line 37:      * </code>
Line 38:      * @param entityList
s/entityList/entities
Line 39:      * @return
Line 40:      */
Line 41:     public static <E extends Nameable> Map<String, E> 
entitiesByName(Collection<E> entityList) {
Line 42:         if (entityList != null) {


Line 37:      * </code>
Line 38:      * @param entityList
Line 39:      * @return
Line 40:      */
Line 41:     public static <E extends Nameable> Map<String, E> 
entitiesByName(Collection<E> entityList) {
s/entityList/entities
Line 42:         if (entityList != null) {
Line 43:             Map<String, E> map = new HashMap<String, E>();
Line 44:             for (E e : entityList) {
Line 45:                 map.put(e.getName(), e);


-- 
To view, visit https://gerrit.ovirt.org/33328
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idad75878f66635dd773dc0b30aeb325733152dde
Gerrit-PatchSet: 21
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to