Michael Pasternak has posted comments on this change.
Change subject: restapi: #854932 - remove update non-vm disk option
......................................................................
Patch Set 1: (2 inline comments)
comments inline
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/DiskResource.java
Line 26:
Line 27: @GET
Line 28: @Formatted
Line 29: @Override
Line 30: public Disk get();
ReadOnlyDeviceResource has get() why overriding it? what the point in this
interface?
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/DisksResource.java
Line 26: public Response add(Disk device);
Line 27:
Line 28: @DELETE
Line 29: @Path("{id}")
Line 30: public Response remove(@PathParam("id") String id);
why any change is needed in this interface?
Line 31:
--
To view, visit http://gerrit.ovirt.org/8531
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4839d4495925c71e26e0b4a2feae0d82709883b3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
