Tomas Jelinek has posted comments on this change. Change subject: webadmin: Validate disk model properties before flushing ......................................................................
Patch Set 1: I would move this code to AbstractDiskModel.flush() so it will be used by all the children not only new disk (I know that AttachDisk does not do the validation today but it will be more future-proof). Also, I think the validate() could than be removed from the store() methods since the flush() has to always be called before it and he is the one who is always called while the dialog is still opened, while the store() is called when the dialog is not show anymore in case of instance images. -- To view, visit https://gerrit.ovirt.org/40741 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifa982d1f2fff9c0b90a9a23f9480ce99b20f9e25 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
