Allon Mureinik has uploaded a new change for review. Change subject: core: StorageHandlingCommandBase static comperator ......................................................................
core: StorageHandlingCommandBase static comperator Created a static instance of the stateless LastTimeUsedAsMasterComp to avoid creating a useless new instance each time it's needed. Change-Id: I4509acc5f2ed8ec384ec562a4c73741214f1aeba Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/58/8558/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java index 6dd6f02..b6d053c 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java @@ -288,7 +288,7 @@ storage_domains newMaster = null; if (getStoragePool() != null) { List<storage_domains> storageDomains = getStorageDomainDAO().getAllForStoragePool(getStoragePool().getId()); - Collections.sort(storageDomains, new LastTimeUsedAsMasterComp()); + Collections.sort(storageDomains, LastTimeUsedAsMasterComp.instance); if (storageDomains.size() > 0) { storage_domains storageDomain = getStorageDomain(); for (storage_domains dbStorageDomain : storageDomains) { @@ -372,6 +372,8 @@ } private static final class LastTimeUsedAsMasterComp implements Comparator<storage_domains> { + public static final LastTimeUsedAsMasterComp instance = new LastTimeUsedAsMasterComp(); + @Override public int compare(storage_domains o1, storage_domains o2) { // TODO: When moving to JDK7 - this can be replaced with -- To view, visit http://gerrit.ovirt.org/8558 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4509acc5f2ed8ec384ec562a4c73741214f1aeba Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
