Moti Asayag has uploaded a new change for review. Change subject: engine: Provide a precise feedback about updates ......................................................................
engine: Provide a precise feedback about updates oVirt-node check for available updates should compare the version of the updates to the current version of the installed OS of the ovirt-node. Applying this functionality will prevent the ability to install the same OS version or previous versions on the node via the 'Upgrade' action. Change-Id: If9987cdf2cd4a149083368ddca965055e88fb6cb Bug-Url: https://bugzilla.redhat.com/1157368 Signed-off-by: Moti Asayag <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/OvirtNodeUpgradeManager.java 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/36/40836/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/OvirtNodeUpgradeManager.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/OvirtNodeUpgradeManager.java index 1c507cf..17d17b7 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/OvirtNodeUpgradeManager.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/OvirtNodeUpgradeManager.java @@ -7,6 +7,7 @@ import org.ovirt.engine.core.common.queries.VdcQueryReturnValue; import org.ovirt.engine.core.common.queries.VdcQueryType; import org.ovirt.engine.core.common.queries.VdsIdParametersBase; +import org.ovirt.engine.core.common.utils.RpmVersionUtils; import org.ovirt.engine.core.compat.RpmVersion; public class OvirtNodeUpgradeManager implements UpdateAvailable { @@ -17,6 +18,6 @@ Backend.getInstance().runInternalQuery(VdcQueryType.GetoVirtISOs, new VdsIdParametersBase(host.getId())); List<RpmVersion> isos = returnValue.getReturnValue(); - return !isos.isEmpty(); + return RpmVersionUtils.isUpdateAvailable(isos, host.getHostOs()); } } -- To view, visit https://gerrit.ovirt.org/40836 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If9987cdf2cd4a149083368ddca965055e88fb6cb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
