Juan Hernandez has posted comments on this change. Change subject: restapi: Allow creation of new disks as copy of any existing disk ......................................................................
Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/38367/4/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml File backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml: Line 834: signatures: Line 835: - mandatoryArguments: Line 836: action.storage_domain.id|name: xs:string Line 837: optionalArguments: Line 838: action.name: xs:string If you decide to support both "name" and "alias" it would then be better to use the "disk" element: optionalArguments: action.disk.name|alias: xs:string Line 839: description: copy a disk to a different storage domain Line 840: headers: Line 841: Filter: {value: true|false, required: false} Line 842: - name: /disks|rel=add https://gerrit.ovirt.org/#/c/38367/4/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDiskResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDiskResource.java: Line 108: params.setImageGroupID(asGuid(disk.getId())); Line 109: Line 110: if (action.isSetName() && !StringUtils.isEmpty(action.getName())) { Line 111: params.setNewAlias(action.getName()); Line 112: } If you decide to support both "name" and "alias" you should do something like this: Disk actionDisk = action.getDisk(); if (disk != null) { String name = disk.getName(); String alias = disk.getName(); if (name != null && !String.isEmpty(name)) { params.setNewAlias(name); } else if (alias != null && !String.isEmpty(alias)) { params.setNewAlias(alias); } } Line 113: Line 114: return doAction(VdcActionType.MoveOrCopyDisk, params, action); Line 115: } Line 116: -- To view, visit https://gerrit.ovirt.org/38367 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8931d2464d6ad17a80d9b394f16d01a2c47d7575 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
