Martin Mucha has posted comments on this change. Change subject: engine: Add NetworkAttachment dao ......................................................................
Patch Set 23: (1 comment) https://gerrit.ovirt.org/#/c/32581/23/packaging/dbscripts/upgrade/03_06_1210_add_network_attachment.sql File packaging/dbscripts/upgrade/03_06_1210_add_network_attachment.sql: Line 22: -- id UUID NOT NULL CONSTRAINT pk_network_attachments_id PRIMARY KEY, Line 23: -- network_attachment_id UUID NOT NULL REFERENCES network_attachments (id), Line 24: -- key TEXT, Line 25: -- value TEXT Line 26: --); > I'm really sorry for pushing this. I did some changes in this patch and wan removed. Done. Line 27: Line 28: CREATE INDEX IDX_network_attachments_nic_id ON network_attachments(nic_id); Line 29: Line 30: -- The network attachments should be populated according to existing data taken from vds_interfaces -- To view, visit https://gerrit.ovirt.org/32581 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I84187f3900b9e3f8a917fc4e4126de9e50e231b4 Gerrit-PatchSet: 23 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
