Martin Mucha has posted comments on this change. Change subject: engine: Add NetworkAttachmentValidator ......................................................................
Patch Set 21: (1 comment) https://gerrit.ovirt.org/#/c/33331/21/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java: Line 531: ACTION_TYPE_FAILED_DUPLICATE_NETWORK_CLUSTER_INPUT(ErrorType.BAD_PARAMETERS), Line 532: NETWORK_NOT_EXISTS(ErrorType.BAD_PARAMETERS), Line 533: ACTION_TYPE_FAILED_NETWORK_QOS_NOT_EXISTS(ErrorType.BAD_PARAMETERS), Line 534: NETWORK_NOT_EXISTS_IN_CLUSTER(ErrorType.BAD_PARAMETERS), Line 535: NETWORK_ATTACHMENT_NOT_EXISTS(ErrorType.BAD_PARAMETERS), > Where are the ApplicationErrors.java/properties updates for these new messa at first I did not want to alter motis patches. All translation I found missing are added in Icd0d874f69144fe647ffe9b32bd6fe8f6864e317 Line 536: NETWORK_ALREADY_ATTACHED_TO_HOST(ErrorType.CONFLICT), Line 537: NETWORK_OLD_NETWORK_NOT_SPECIFIED(ErrorType.BAD_PARAMETERS), Line 538: NETWORK_ALREADY_ATTACHED_TO_CLUSTER(ErrorType.CONFLICT), Line 539: NETWORK_CAN_NOT_REMOVE_DEFAULT_NETWORK(ErrorType.CONSTRAINT_VIOLATION), -- To view, visit https://gerrit.ovirt.org/33331 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I908511f4c0f999d82120074c290eccd9e1006cdc Gerrit-PatchSet: 21 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
