Allon Mureinik has posted comments on this change.
Change subject: core: show iqn in audit log when SD partially inaccessible
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
minor suggestion
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java
Line 183: Guid connectionGuid =
Guid.createGuidFromString(connection.getid());
Line 184: if (connectionGuid.equals(connectionIdGuid)) {
Line 185: String desc = connection.getconnection();
Line 186: if (connection.getiqn() != null) {
Line 187: desc = desc + " " + connection.getiqn();
I'd use +=, or a StringBuilder.
Line 188: }
Line 189: return desc;
Line 190: }
Line 191: }
--
To view, visit http://gerrit.ovirt.org/8598
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If6f4f4c5e176e06cceeda7a7fed29565eead369b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Greg Padgett <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
