[Engine-patches] Change in ovirt-engine[master]: core: Use ThreadPoolUtil instead of new Thread

[rgolan]

Hello Martin Sivák, Gilad Chaplik,

I'd like you to do a code review.  Please visit

    https://gerrit.ovirt.org/40912

to review the following change.

Change subject: core: Use ThreadPoolUtil instead of new Thread
......................................................................

core: Use ThreadPoolUtil instead of new Thread

use Runnable instead of new Thread. only our ThreadPoolUtil should
supply that resources and we should keep it.

Change-Id: If377e0241190d55b6d0960ff456717b3707edb34
Signed-off-by: Roy Golan <rgo...@redhat.com>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
R 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerDiscovery.java
2 files changed, 10 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/12/40912/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
index 2141e53..89b00fa 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
@@ -19,7 +19,7 @@
 
 import org.apache.commons.lang.StringUtils;
 import org.apache.commons.lang.math.NumberUtils;
-import 
org.ovirt.engine.core.bll.scheduling.external.ExternalSchedulerDiscoveryThread;
+import 
org.ovirt.engine.core.bll.scheduling.external.ExternalSchedulerDiscovery;
 import org.ovirt.engine.core.bll.scheduling.external.ExternalSchedulerFactory;
 import org.ovirt.engine.core.common.AuditLogType;
 import org.ovirt.engine.core.common.businessentities.BusinessEntity;
@@ -46,6 +46,7 @@
 import org.ovirt.engine.core.dao.VdsGroupDAO;
 import org.ovirt.engine.core.dao.scheduling.ClusterPolicyDao;
 import org.ovirt.engine.core.dao.scheduling.PolicyUnitDao;
+import org.ovirt.engine.core.utils.threadpool.ThreadPoolUtil;
 import org.ovirt.engine.core.utils.timer.OnTimerMethodAnnotation;
 import org.ovirt.engine.core.utils.timer.SchedulerUtilQuartzImpl;
 import org.slf4j.Logger;
@@ -61,7 +62,7 @@
 
     private AuditLogDirector auditLogDirector;
     @Inject
-    private Instance<ExternalSchedulerDiscoveryThread> 
exSchedulerDiscoveryProvider;
+    private Instance<ExternalSchedulerDiscovery> exSchedulerDiscoveryProvider;
 
     private static final Logger log = 
LoggerFactory.getLogger(SchedulingManager.class);
 
@@ -99,12 +100,12 @@
         log.info("Initializing Scheduling manager");
         loadPolicyUnits();
         loadClusterPolicies();
-        ExternalSchedulerDiscoveryThread discoveryThread = 
exSchedulerDiscoveryProvider.get();
+        ExternalSchedulerDiscovery discovery = 
exSchedulerDiscoveryProvider.get();
         if (Config.<Boolean>getValue(ConfigValues.ExternalSchedulerEnabled)) {
-            log.info("Starting external scheduler discovery thread");
-            discoveryThread.start();
+            log.info("Starting external scheduler discovery");
+            ThreadPoolUtil.execute(discovery);
         } else {
-            discoveryThread.markAllExternalPoliciesAsDisabled();
+            discovery.markAllExternalPoliciesAsDisabled();
             log.info("External scheduler disabled, discovery skipped");
         }
         enableLoadBalancer();
diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerDiscoveryThread.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerDiscovery.java
similarity index 97%
rename from 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerDiscoveryThread.java
rename to 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerDiscovery.java
index 314ef1f..cc64f4f 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerDiscoveryThread.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerDiscovery.java
@@ -21,14 +21,14 @@
 
 import javax.inject.Inject;
 
-public class ExternalSchedulerDiscoveryThread extends Thread {
+public class ExternalSchedulerDiscovery implements Runnable {
 
     @Inject
     private SchedulingManager schedulingManager;
 
-    private final static Logger log = 
LoggerFactory.getLogger(ExternalSchedulerDiscoveryThread.class);
+    private final static Logger log = 
LoggerFactory.getLogger(ExternalSchedulerDiscovery.class);
 
-    private ExternalSchedulerDiscoveryThread() {}
+    private ExternalSchedulerDiscovery() {}
 
     @Override
     public void run() {


-- 
To view, visit https://gerrit.ovirt.org/40912
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If377e0241190d55b6d0960ff456717b3707edb34
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Martin Sivák <msi...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches