Karnan t c has posted comments on this change.

Change subject: engine: Added new alerts for brick/volume status changes
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/40566/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java:

Line 1009:         logUtil.logAuditMessage(volume.getClusterId(), volume, null,
Line 1010:                 AuditLogType.GLUSTER_BRICK_STATUS_DOWN, 
brick.getId(), brick.getQualifiedName(),
Line 1011:                 new HashMap<String, String>() {
Line 1012:                     {
Line 1013:                         put(GlusterConstants.BRICK_PATH, 
brick.getQualifiedName());
> are these custom values required since you have set the brick path?
Thanks for pointing out. removed.
Line 1014:                     }
Line 1015:                 });
Line 1016:         }else if(fetchedStatus == GlusterStatus.UP){
Line 1017:             
AlertDirector.RemoveAlertsByBrickIdLogType(brick.getId(), 
AuditLogType.GLUSTER_BRICK_STATUS_DOWN);


https://gerrit.ovirt.org/#/c/40566/2/backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
File 
backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties:

Line 850: GLUSTER_SERVICE_RESTARTED=${servicetype} service re-started on host 
${VdsName} on cluster ${VdsGroupName}.
Line 851: GLUSTER_SERVICE_RESTART_FAILED=Could not re-start ${servicetype} 
service on host ${VdsName} on cluster ${VdsGroupName}.
Line 852: GLUSTER_VOLUME_BRICK_ADDED=Brick [${brickpath}] on host 
[${servername}] added to volume [${glusterVolumeName}]
Line 853: GLUSTER_BRICK_STATUS_CHANGED=Detected change in status of brick 
${brickpath} of volume ${glusterVolumeName} from ${oldValue} to ${newValue}.
Line 854: GLUSTER_BRICK_STATUS_DOWN=Status of brick ${brickpath} of volume 
${glusterVolumeName} is down.
> vdsGroupName also in the message
Done
Line 855: GLUSTER_GEOREP_SESSION_DELETED_FROM_CLI=Detected deletion of 
geo-replication session ${geoRepSessionKey} from volume ${glusterVolumeName}
Line 856: GLUSTER_GEOREP_SESSION_DETECTED_FROM_CLI=Detected new geo-replication 
session ${geoRepSessionKey} for volume ${glusterVolumeName}. Adding it to 
engine.
Line 857: GLUSTER_GEOREP_SESSION_REFRESH=Refreshed geo-replication sessions for 
volume ${glusterVolumeName}.
Line 858: GLUSTER_GEOREP_SESSION_REFRESH_FAILED=Failed to refresh 
geo-replication sessions for volume ${glusterVolumeName}.


-- 
To view, visit https://gerrit.ovirt.org/40566
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibad5ed6078bd33cd9c9decdabca6747709be4ba4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Karnan t c <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Karnan t c <[email protected]>
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to