Juan Hernandez has posted comments on this change.
Change subject: restapi: Extend VM with provider id
......................................................................
Patch Set 3:
(2 comments)
Are all kinds of external host providers supposed to provide hosts and also
errata? Foreman, for example, doesn't provide errata. Can a VM be provisioned
by one system (Foreman for example) and get errata from a different one? If the
answer to any of these questions is yes then there should be two elements, not
one:
<vm>
...
<external_host_provider id="a" href="..."/>
</katello_errata_provider id="b" href="..."/>
</vm>
There should also be a top level collection for errata providers.
https://gerrit.ovirt.org/#/c/40719/3//COMMIT_MSG
Commit Message:
Line 13: (Foreman/Satellite).
Line 14:
Line 15: <vm>
Line 16: ...
Line 17: <provider id="..." href="..." />
Should be "external_host_provider", like in the rest of the patch?
Line 18: </vm>
Line 19:
Line 20: Change-Id: Ia923483e6ff8de8dc16dde84e61818472f59a944
Line 21: Bug-Url: https://bugzilla.redhat.com/1157377
https://gerrit.ovirt.org/#/c/40719/3/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
File
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml:
Line 98: vm.start_paused: xs:boolean
Line 99: vm.cpu_profile.id: xs:string
Line 100: vm.migration.auto_converge: xs:string
Line 101: vm.migration.compressed: xs:string
Line 102: vm.external_host_provider.id: 'xs:string'
Avoid the quotes around xs:string.
Line 103: description: update the virtual machine in the system for the
given virtual machine id with the values specified in the request
Line 104: - name: /vms/{vm:id}/applications|rel=get
Line 105: description: get all the applications installed on the vm
identified by the given id
Line 106: request:
--
To view, visit https://gerrit.ovirt.org/40719
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia923483e6ff8de8dc16dde84e61818472f59a944
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
