Moti Asayag has posted comments on this change. Change subject: engine: Introduce queries for vms errata ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/40720/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetErrataForVmQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetErrataForVmQuery.java: Line 35: Line 36: Provider<?> provider = providerDao.get(vm.getProviderId()); Line 37: if (provider != null) { Line 38: HostProviderProxy proxy = (HostProviderProxy) ProviderProxyFactory.getInstance().create(provider); Line 39: getQueryReturnValue().setReturnValue(proxy.getErrataForHost(vm.getVmFQDN())); > Shall we have a "fallback" to use the vmName in case the FQDN is empty? wha the field was repalced with VmHost. replacing the field with vm_name seems a bit problematic, since users might modify it, either accidentaly or not. in order to enable errata for vm, the user should install katello-agent and register the vm to katello. Than the vm will be identified as a content-host by its FQDN. We should stick for that assumption. Line 40: } else { Line 41: getQueryReturnValue().setReturnValue(Collections.<Erratum> emptyList()); Line 42: } Line 43: } -- To view, visit https://gerrit.ovirt.org/40720 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id3b2e149f64eb55d30bb093b5d82c68401edc5a3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
