Allon Mureinik has posted comments on this change.
Change subject: core: Added a query to retrieve storage domains by connection id
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
The code itself looks OK, but I'd merge this patch into the next one - on it's
own, this introduces dead code.
....................................................
File
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageDomainDAOTest.java
Line 25: private static final Guid EXISTING_STORAGE_POOL_ID = new
Guid("6d849ebf-755f-4552-ad09-9a090cda105d");
Line 26: private static final String EXISTING_CONNECTION = "10.35.64.25";
Line 27: private static final Guid EXISTING_USER_ID = new
Guid("9bf7c640-b620-456f-a550-0348f366544b");
Line 28: private static final Guid EXISTING_CONNECTION_ID = new
Guid("7fe9a439-a68e-4c15-8885-29d34eb6cabf");
Line 29: private static final Guid EXISTING_DOMAIN_ID_FOR_CONNECTION_ID =
new Guid("c2211b56-8869-41cd-84e1-78d7cb96f31d");
Please move these to Fixtures.java
Line 30:
Line 31: private StorageDomainDAO dao;
Line 32: private storage_domains existingDomain;
Line 33: private storage_domain_static newStaticDomain;
--
To view, visit http://gerrit.ovirt.org/8604
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I45c5d09c5358ad6378761ad3d8d2ae30863ea92a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
