Eli Mesika has posted comments on this change. Change subject: core: Extend Vm[Static] to contain provider id ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/40717/4/packaging/dbscripts/create_views.sql File packaging/dbscripts/create_views.sql: Line 1106: vm_dynamic.guest_mem_cached as guest_mem_cached, Line 1107: vm_dynamic.guest_mem_free as guest_mem_free, Line 1108: vm_static.small_icon_id as small_icon_id, Line 1109: vm_static.large_icon_id as large_icon_id, Line 1110: vm_static.provider_id as provider_id > haven't found justification for it. why do you think it is required ? if this new field is exposed by the search engine and tags are used it will not be set correctly Up to now, from that reason , we added all new field to <E> and <E>_with_tags views Line 1111: FROM Line 1112: vm_static Line 1113: INNER JOIN vm_dynamic ON vm_static.vm_guid = vm_dynamic.vm_guid Line 1114: INNER JOIN vm_static AS vm_templates ON vm_static.vmt_guid = vm_templates.vm_guid -- To view, visit https://gerrit.ovirt.org/40717 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c09188dcde40cbb5904dc15274d597ceb9b8594 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
