Moti Asayag has posted comments on this change. Change subject: core[DAO]: Adding external status to DAOs ......................................................................
Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/40994/3/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAODbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAODbFacadeImpl.java: Line 165: .addValue("vds_guid", id) Line 166: .addValue("external_status", status); Line 167: Line 168: getCallsHandler().executeModification("UpdateVdsDynamiciExternalStatus", parameterSource); Line 169: } maybe just UpdateExternalStatus ? (it is already in the context of VdsDynamic, so no need to repeat it). Line 170: Line 171: @Override Line 172: public void updateNetConfigDirty(Guid id, Boolean netConfigDirty) { Line 173: MapSqlParameterSource parameterSource = getCustomMapSqlParameterSource() https://gerrit.ovirt.org/#/c/40994/3/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsDynamicDAOTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsDynamicDAOTest.java: Line 120: VdsDynamic before = dao.get(existingVds.getId()); Line 121: before.setExternalStatus(ExternalStatus.Error); Line 122: dao.updateExternalStatus(before.getId(), before.getExternalStatus()); Line 123: VdsDynamic after = dao.get(existingVds.getId()); Line 124: assertEquals(before, after); please compare the externalStatus fields explicitly. Line 125: } Line 126: Line 127: Line 128: @Test -- To view, visit https://gerrit.ovirt.org/40994 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie4dd9a1bc0aa99604f74a07155a7b596585e3ccf Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
