Tomas Jelinek has posted comments on this change.

Change subject: engine: Integrate smartcard support
......................................................................


Patch Set 7: (2 inline comments)

....................................................
File 
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateReader.java
Line 140:     }
Line 141: 
Line 142:     @Override
Line 143:     protected void readGeneralData(XmlNode content) {
Line 144:         // General Vm
but the super is abstract
Line 145:         XmlNode node = content.SelectSingleNode("Name");
Line 146:         if (node != null) {
Line 147:             _vmTemplate.setname(node.InnerText);
Line 148:             name = _vmTemplate.getname();


....................................................
File 
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java
Line 139:     }
Line 140: 
Line 141:     @Override
Line 142:     protected void readGeneralData(XmlNode content) {
Line 143:         // General Vm
but the super is abstract
Line 144:         XmlNode node = content.SelectSingleNode("Name");
Line 145:         if (node != null) {
Line 146:             _vm.getStaticData().setvm_name(node.InnerText);
Line 147:             name = _vm.getStaticData().getvm_name();


--
To view, visit http://gerrit.ovirt.org/8484
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icaa874d6316c4040253231a7a301a17d8b69eb4b
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to