Omer Frenkel has posted comments on this change.
Change subject: core: don't re-migrate vm after migration was canceled (#867347)
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CancelMigrateVDSCommand.java
Line 13: protected void ExecuteVdsBrokerCommand() {
Line 14: Guid vmId = getParameters().getVmId();
Line 15: status = getBroker().migrateCancel(vmId.toString());
Line 16: ProceedProxyReturnValue();
Line 17: ResourceManager.getInstance().RemoveAsyncRunningVm(vmId);
i don't think there is a way that the vm will not be in the list,
but even in this case, nothing will happen, as remove is safe even if key is
not in the map/hash
Line 18: }
--
To view, visit http://gerrit.ovirt.org/8658
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a8bf38bef90e5dfd0458cc13b8bb704f11d9f58
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
