Sharad Mishra has uploaded a new change for review. Change subject: core: ImagesHandler cleanup. ......................................................................
core: ImagesHandler cleanup. FindBugs issue - ImagesHandler.java:685, MS_SHOULD_BE_FINAL, Priority: Low org.ovirt.engine.core.bll.ImagesHandler.log isn't final but should be A mutable static field could be changed by malicious code or by accident from another package. The field could be made final to avoid this vulnerability. Change-Id: I744b65dc531357c079560017b85087ae01d1ec2a Signed-off-by: Sharad Mishra <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/87/8687/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java index 1a9fedf..3a97723 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java @@ -53,6 +53,7 @@ private static final String DISK = "_Disk"; public static final Guid BlankImageTemplateId = new Guid("00000000-0000-0000-0000-000000000000"); public static final String DefaultDriveName = "1"; + protected static final Log log = LogFactory.getLog(ImagesHandler.class); /** * The following method will find all images and storages where they located for provide template and will fill an @@ -682,6 +683,5 @@ DbFacade.getInstance().getBaseDiskDao().remove(diskId); } - protected static Log log = LogFactory.getLog(ImagesHandler.class); } -- To view, visit http://gerrit.ovirt.org/8687 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I744b65dc531357c079560017b85087ae01d1ec2a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
