Sandro Bonazzola has posted comments on this change. Change subject: hosted-engine: configure gluster for HC ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/39678/1/src/plugins/ovirt-host-deploy/hosted-engine/glusterd.py File src/plugins/ovirt-host-deploy/hosted-engine/glusterd.py: Line 63: continue Line 64: elif line.find('base-port') != -1: Line 65: continue Line 66: elif line.find('end-volume') == 0: Line 67: content.append(' option rpc-auth-allow-insecure on') > Yes, only as many ports as number of bricks on the node. So we can drop this patch at all right? we just need to require gluster 3.7.1 once it's out for handling rpc-auth-allow-insecure. Line 68: content.append(' option base-port 49217') Line 69: content.append(line) Line 70: Line 71: self.environment[otopicons.CoreEnv.MAIN_TRANSACTION].append( -- To view, visit https://gerrit.ovirt.org/39678 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2bded0891309a2d38daef76bac93c7c7a4b0602a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Vijay Bellur <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
