Vinzenz Feenstra has posted comments on this change. Change subject: linux: Logout active user support ......................................................................
Patch Set 4: Code-Review+2 Verified+1 (1 comment) https://gerrit.ovirt.org/#/c/35416/4/scripts/wrappers/ovirt-logout-wrapper.sh File scripts/wrappers/ovirt-logout-wrapper.sh: Line 16: # Line 17: # Refer to the README and COPYING files for full details of the license. Line 18: # Line 19: Line 20: /usr/share/ovirt-guest-agent/LogoutActiveUser.py $@ &> /dev/null > nit question - isn't &> bash specific? Possibly, however we have it the same in ovirt-locksession-wrapper.sh https://github.com/oVirt/ovirt-guest-agent/blob/master/scripts/wrappers/ovirt-locksession-wrapper.sh So I will leave it the same way for now and we can update it later on in a different patchset. Line 21: -- To view, visit https://gerrit.ovirt.org/35416 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1173dc8cb6c2bd68b5e2a2ba4ad69284b2085171 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
