Tomas Jelinek has posted comments on this change. Change subject: frontend: support for noVNC 0.5 ......................................................................
Patch Set 1: (2 comments) only minor comments - in general looks good https://gerrit.ovirt.org/#/c/41393/1/backend/manager/modules/services/src/main/webapp/novnc-main.html File backend/manager/modules/services/src/main/webapp/novnc-main.html: Line 65: isOldNoVnc = true; Line 66: Line 67: var extra = "", start, end; Line 68: Line 69: start = "<script src='files/novnc/include/"; I would use the INCLUDE_URI also here Line 70: end = "'><\/script>"; Line 71: Line 72: extra += start + "webutil.js" + end; Line 73: extra += start + "base64.js" + end; Line 154: rfbParams.onUpdateState = updateState; Line 155: } Line 156: Line 157: rfb = new RFB(rfbParams); Line 158: rfb.connect(host, port, password, path); please fix indent Line 159: }catch(e) {alert(e);} Line 160: } Line 161: Line 162: function receiveEvtData(evt) { -- To view, visit https://gerrit.ovirt.org/41393 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6dee16a76627df8b168d40619c8b383f5ff5552c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
