Mike Kolesnik has posted comments on this change. Change subject: core: Query GetVdsAndNetworkInterfacesByNetworkId ......................................................................
Patch Set 8: (1 inline comment) Please add test for the VdsInterfaceDao's new method .................................................... File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVdsAndNetworkInterfacesByNetworkIdQueryTest.java Line 35: Line 36: setupVdsDao(); Line 37: setupVdsNetworkInterfaceDao(); Line 38: Line 39: Pair<VdsNetworkInterface, VDS> VdsInterfaceVdsPair = new Pair(vdsNetworkInterface, vds); Name should start with lower letter. Line 40: List<Pair<VdsNetworkInterface, VDS>> expected = Collections.singletonList(VdsInterfaceVdsPair); Line 41: Line 42: // Run the query Line 43: GetVdsAndNetworkInterfacesByNetworkIdQuery<NetworkIdParameters> query = getQuery(); -- To view, visit http://gerrit.ovirt.org/8499 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If53281fdc70c9fb2b19145e62bb8f0a5ae3491c0 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msa...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Muli Salem <msa...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
