Shubhendu Tripathi has posted comments on this change. Change subject: gluster: Add audit log message while volume snapshot sync ......................................................................
Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/41385/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSnapshotSyncJob.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSnapshotSyncJob.java: Line 151: null, > Why not volume in the audit log. Snapshot names are meaningful only with th Thats correct, but here in this flow there is not volume name available. We are looking at snapshot for a cluster as whole at a time. So there is no way to get the volume name here. https://gerrit.ovirt.org/#/c/41385/2/backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties File backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties: Line 901: > Volume name can also be added to the audit log. Same as earlier comment on java source -- To view, visit https://gerrit.ovirt.org/41385 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I81636a86f48e977f47a4e5cbbd042446e3483ddf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
