Piotr Kliczewski has posted comments on this change. Change subject: Bug 1220838 - Log messages received from vdsm ......................................................................
Patch Set 2: (4 comments) https://gerrit.ovirt.org/#/c/41506/2//COMMIT_MSG Commit Message: Line 1: Parent: 3de3c310 (core: Enable creation of non-stateless VMs from 'latest' templates) Please remove white spaces. Line 2: Author: mmirecki <[email protected]> Line 3: AuthorDate: 2015-05-27 14:24:08 +0200 Line 4: Commit: mmirecki <[email protected]> Line 5: CommitDate: 2015-05-27 15:57:48 +0200 Line 3: AuthorDate: 2015-05-27 14:24:08 +0200 Line 4: Commit: mmirecki <[email protected]> Line 5: CommitDate: 2015-05-27 15:57:48 +0200 Line 6: Line 7: Bug 1220838 - Log messages received from vdsm please use: vdsbroker: Log messages for failed invocation Line 8: Line 9: Description of problem: Line 10: When messages from vdsm are received user have no ability to understand Line 11: whether hooks failed. Line 5: CommitDate: 2015-05-27 15:57:48 +0200 Line 6: Line 7: Bug 1220838 - Log messages received from vdsm Line 8: Line 9: Description of problem: Please use Bug-url: instead of copying BZ description. Line 10: When messages from vdsm are received user have no ability to understand Line 11: whether hooks failed. Line 12: We need to audit 'message' content when non-zero codes are return for Line 13: all commands except: https://gerrit.ovirt.org/#/c/41506/2/backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties File backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties: Line 1001: HOST_UPGRADE_STARTED=Host ${VdsName} upgrade was started (User: ${UserName}). Line 1002: HOST_UPGRADE_FAILED=Failed to upgrade Host ${VdsName} (User: ${UserName}). Line 1003: HOST_UPGRADE_FINISHED=Host ${VdsName} upgrade was completed successfully. Line 1004: VDS_BROKER_COMMAND_FAILURE=VDSM ${VdsName} command failed: ${message} Line 1005: IRS_BROKER_COMMAND_FAILURE=IRS command failed: ${message} Users are not aware of IRS meaning. I would use single message here for both. -- To view, visit https://gerrit.ovirt.org/41506 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I811c2c988f7cd8ce4963313266154b7ecbc775f0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
