Eli Mesika has posted comments on this change. Change subject: core: getAllByStoragePoolIdFilteredByActiveStorageDomains ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/41563/1/packaging/dbscripts/libvirt_secrets_sp.sql File packaging/dbscripts/libvirt_secrets_sp.sql: Line 86: END; $procedure$ Line 87: LANGUAGE plpgsql; Line 88: Line 89: Line 90: Create or replace FUNCTION GetAllLibvirtSecretsAllByStoragePoolIdFilteredByActiveDomains(v_storage_pool_id UUID) You are almost reached max name length (63) : The system uses no more than NAMEDATALEN-1 bytes of an identifier; longer names can be written in commands, but they will be truncated. By default, NAMEDATALEN is 64 so the maximum identifier length is 63 bytes. can you make the name shorter , like GetAllLibvirtSecretsByStoragePoolId I believe that everyone can understand the filter from the where clause Line 91: RETURNS SETOF libvirt_secrets STABLE Line 92: AS $procedure$ Line 93: BEGIN Line 94: RETURN QUERY SELECT libvirt_secrets.* -- To view, visit https://gerrit.ovirt.org/41563 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae886c19afbabd11f013b17e5d304aaf9c199b09 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
