Eli Mesika has posted comments on this change. Change subject: core: introduce LibvirtSecretDao ......................................................................
Patch Set 1: (3 comments) https://gerrit.ovirt.org/#/c/41551/1/packaging/dbscripts/libvirt_secrets_sp.sql File packaging/dbscripts/libvirt_secrets_sp.sql: Line 24: RETURNS VOID Line 25: AS $procedure$ Line 26: BEGIN Line 27: Line 28: INSERT INTO libvirt_secrets(secret_uuid, secret_value, secret_usage_type, secret_description, provider_id, creation_date) please try to keep one column in a line, I am going to force that in future , without that it is very hard to track changes on gerrit Line 29: VALUES(v_secret_uuid, v_secret_value, v_secret_usage_type, v_secret_description, v_provider_id, v_creation_date); Line 30: Line 31: END; $procedure$ Line 32: LANGUAGE plpgsql; Line 25: AS $procedure$ Line 26: BEGIN Line 27: Line 28: INSERT INTO libvirt_secrets(secret_uuid, secret_value, secret_usage_type, secret_description, provider_id, creation_date) Line 29: VALUES(v_secret_uuid, v_secret_value, v_secret_usage_type, v_secret_description, v_provider_id, v_creation_date); same Line 30: Line 31: END; $procedure$ Line 32: LANGUAGE plpgsql; Line 33: Line 42: AS $procedure$ Line 43: BEGIN Line 44: Line 45: UPDATE libvirt_secrets Line 46: SET secret_uuid = v_secret_uuid, secret_value = v_secret_value, secret_usage_type = v_secret_usage_type, same Line 47: secret_description = v_secret_description, provider_id = v_provider_id, creation_date = v_creation_date, Line 48: _update_date = LOCALTIMESTAMP Line 49: WHERE secret_uuid = v_secret_uuid; Line 50: -- To view, visit https://gerrit.ovirt.org/41551 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33625086f2f7bcaef755b8e75b8ba07f688f33b2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
