Maor Lipchuk has posted comments on this change.

Change subject: core: Update Cinder maximum volume validation.
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/41134/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/CinderDisksValidator.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/CinderDisksValidator.java:

Line 72:                                 String.format("$storageName %s", 
storageName));
> can you add the diskAliases as well?
we are now validating this with number of disks, so there is no really use for 
the disk alias.
How will the disk alias will have any meaning for the user?


-- 
To view, visit https://gerrit.ovirt.org/41134
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If8c3901db7eaf4c9361571fc14ac4b11218a9ff4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to