Eli Mesika has posted comments on this change.

Change subject: backend: change template1 to utf8 encoding.
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File backend/manager/dbscripts/create_db.sh
Line 45: printf "Creating the database: ${DATABASE}\n"
Line 46: #try to drop the database first (if exists)
Line 47: dropdb --username=${USERNAME} --host=${SERVERNAME} --port=${PORT} 
${DATABASE} -e > /dev/null
Line 48: #change template1 to UTF8 encoding
Line 49: execute_file "alter_encoding.sql" postgres ${SERVERNAME} ${PORT} > 
/dev/null
This should be ${USERNAME} instead of postgres
Line 50: createdb --username=${USERNAME} --host=${SERVERNAME} --port=${PORT} 
${DATABASE} -e -E UTF8 > /dev/null
Line 51: if [ $? -ne 0 ]
Line 52:     then
Line 53:       printf "Failed to create database ${DATABASE}\n"


--
To view, visit http://gerrit.ovirt.org/8744
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3da279df011087d8fb4ac1f61fe9637baac11e1a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ohad Basan <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Ohad Basan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to