Michael Kublin has posted comments on this change.
Change subject: core: LiveMigrateDisk enterprise readiness
......................................................................
Patch Set 14: I would prefer that you didn't submit this
(2 inline comments)
The class MoveDiskCommand can be used as reference example for some one who
wants implement "Matryoshka doll" design pattern.
Now, we have cyclic references, "Matryoshka doll" design pattern, code
duplications, I am just not used for such style of coding. (There are still
missing some other great design patterns....)
Can you please move all your implementation from CommandBase to some base class
of storage flows or make some abstract class for storage scenarios? .
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveDiskCommand.java
Line 9: import org.ovirt.engine.core.common.action.VdcActionType;
Line 10: import org.ovirt.engine.core.common.businessentities.VM;
Line 11: import org.ovirt.engine.core.common.businessentities.VMStatus;
Line 12: import org.ovirt.engine.core.compat.Guid;
Line 13:
These class is can be used as reference example for implementing "Matryoshka
doll" design pattern.
Line 14: @SuppressWarnings("serial")
Line 15: public class MoveDiskCommand<T extends MoveDiskParameters> extends
BaseImagesCommand<T> {
Line 16: public MoveDiskCommand(Guid commandId) {
Line 17: super(commandId);
Line 84: protected VdcActionType getActionType() {
Line 85: return cmd.getActionType();
Line 86: }
Line 87:
Line 88: @Override
These method is useless.
Line 89: protected void freeLock() {
Line 90: cmd.freeLock();
Line 91: }
Line 92:
--
To view, visit http://gerrit.ovirt.org/8530
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebc2ca95371230d60d08a4961f9c9926b2c813c7
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
