Alona Kaplan has posted comments on this change. Change subject: webadmin: Hiding virt network fields in gluster mode ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/41480/4/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java: Line 439: vlanTagging.setVisible(false); Line 440: vlanTag.setVisible(false); Line 441: exportLabel.setVisible(false); Line 442: exportEditor.setVisible(false); Line 443: profilesTab.setVisible(false); The profiles tab is visible just for vm networks. Since in case the mode is not VirtOnly the network is for sure not vm network, there is no need to explicitly changing the visibility of the profiles tab. Line 444: } Line 445: } Line 446: Line 447: @Override -- To view, visit https://gerrit.ovirt.org/41480 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9380697adc0c6e1d698e7aacc1f9b47be0d3851 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
