Michael Pasternak has posted comments on this change.

Change subject: rest: Support filtered capabilities (#868949)
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File 
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java
Line 136:         version.setMajor(v.getMajor());
Line 137:         version.setMinor(v.getMinor());
Line 138:         version.setId(generateId(v));
Line 139: 
Line 140:         version.setCpus(new CPUs());
please move this ^ row in to the if clause as well (no need to show empty CPUs 
to user)
Line 141: 
Line 142:         if (!isFiltered()) {
Line 143:             for (ServerCpu sc : getServerCpuList(v)) {
Line 144:                 CPU cpu = new CPU();


--
To view, visit http://gerrit.ovirt.org/8764
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I549e680226f0d802872915b8a46c9e5a8c322b44
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to