Daniel Erez has posted comments on this change. Change subject: core: register secrets on connect storage domain ......................................................................
Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/41558/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CINDERStorageHelper.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CINDERStorageHelper.java: Line 61: List<LibvirtSecret> libvirtSecrets = getLibvirtSecretDao().getAllByProviderId(provider.getId()); Line 62: if (!libvirtSecrets.isEmpty()) { Line 63: VDSReturnValue returnValue = Backend.getInstance().getResourceManager().RunVdsCommand( Line 64: VDSCommandType.RegisterLibvirtSecrets, Line 65: new RegisterLibvirtSecretsVDSParameters(vdsId, libvirtSecrets)); > Don't you need to also add try/catch here? 1. done 2. can't use 'runVdsCommand' as this class extends StorageHelperBase Line 66: if (!returnValue.getSucceeded()) { Line 67: addMessageToAuditLog(AuditLogType.FAILED_TO_REGISTER_LIBVIRT_SECRET, Line 68: storageDomain.getName(), vds.getName()); Line 69: log.error("Failed to register libvirt secret for storage domain {} on vds {}.", -- To view, visit https://gerrit.ovirt.org/41558 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I832147a33183139ade488e161b496858413d43f5 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
