Tomas Jelinek has uploaded a new change for review. Change subject: webadmin,userportal: made DynamicMessages accessible in uicommonweb ......................................................................
webadmin,userportal: made DynamicMessages accessible in uicommonweb Extracted the DynamicMessages interface to uicommonweb project and made it accessible to the models using the TypeResolver Change-Id: If2430ac25d91b31be05b224d2c860f0905341279 Signed-off-by: Tomas Jelinek <[email protected]> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseSystemModule.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/ConsolePopupPresenterWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/UiCommonDefaultTypeResolver.java R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/BaseDynamicMessages.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/ConsolePopupView.java M frontend/webadmin/modules/gwt-common/src/test/java/org/ovirt/engine/ui/common/utils/DynamicMessagesTest.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/DynamicMessages.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationDynamicMessages.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicDetailsPresenterWidget.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicDetailsView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationDynamicMessages.java 11 files changed, 151 insertions(+), 100 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/47/41947/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseSystemModule.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseSystemModule.java index 0e1c761..240c182 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseSystemModule.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseSystemModule.java @@ -16,7 +16,6 @@ import org.ovirt.engine.ui.common.system.ErrorPopupManagerImpl; import org.ovirt.engine.ui.common.system.LockInteractionManager; import org.ovirt.engine.ui.common.uicommon.ClientAgentType; -import org.ovirt.engine.ui.common.utils.DynamicMessages; import org.ovirt.engine.ui.common.utils.HttpUtils; import org.ovirt.engine.ui.frontend.AppErrors; import org.ovirt.engine.ui.frontend.Frontend; @@ -29,6 +28,7 @@ import org.ovirt.engine.ui.frontend.communication.XsrfRpcRequestBuilder; import org.ovirt.engine.ui.frontend.gwtservices.GenericApiGWTService; import org.ovirt.engine.ui.frontend.gwtservices.GenericApiGWTServiceAsync; +import org.ovirt.engine.ui.uicommonweb.DynamicMessages; import org.ovirt.engine.ui.uicommonweb.ErrorPopupManager; import com.google.gwt.core.client.GWT; diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/ConsolePopupPresenterWidget.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/ConsolePopupPresenterWidget.java index 572d2da..e4bedc8 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/ConsolePopupPresenterWidget.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/ConsolePopupPresenterWidget.java @@ -8,9 +8,9 @@ import org.ovirt.engine.ui.common.CommonApplicationConstants; import org.ovirt.engine.ui.common.gin.AssetProvider; import org.ovirt.engine.ui.common.presenter.AbstractModelBoundPopupPresenterWidget; -import org.ovirt.engine.ui.common.utils.DynamicMessages; import org.ovirt.engine.ui.uicommonweb.ConsoleOptionsFrontendPersister; import org.ovirt.engine.ui.uicommonweb.ConsoleUtils; +import org.ovirt.engine.ui.uicommonweb.DynamicMessages; import org.ovirt.engine.ui.uicommonweb.UICommand; import org.ovirt.engine.ui.uicommonweb.models.ConsolePopupModel; import org.ovirt.engine.ui.uicommonweb.models.ConsoleProtocol; diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/UiCommonDefaultTypeResolver.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/UiCommonDefaultTypeResolver.java index 80fd6bd..dc2b372 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/UiCommonDefaultTypeResolver.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/UiCommonDefaultTypeResolver.java @@ -7,6 +7,7 @@ import org.ovirt.engine.ui.uicommonweb.Configurator; import org.ovirt.engine.ui.uicommonweb.ConsoleOptionsFrontendPersister; import org.ovirt.engine.ui.uicommonweb.ConsoleUtils; +import org.ovirt.engine.ui.uicommonweb.DynamicMessages; import org.ovirt.engine.ui.uicommonweb.ErrorPopupManager; import org.ovirt.engine.ui.uicommonweb.ILogger; import org.ovirt.engine.ui.uicommonweb.ITimer; @@ -41,6 +42,7 @@ private final Provider<IRdpNative> rdpNativeProvider; private final Provider<IVncNative> vncNativeProvider; private final Provider<INoVnc> noVncProvider; + private final DynamicMessages dynamicMessages; private String sessionId; @@ -56,7 +58,8 @@ Provider<IRdpPlugin> rdpPluginProvider, Provider<IRdpNative> rdpNativeProvider, Provider<IVncNative> vncNativeProvider, - Provider<INoVnc> noVncProvider) { + Provider<INoVnc> noVncProvider, + DynamicMessages dynamicMessages) { this.configurator = configurator; this.logger = logger; this.consoleOptionsFrontendPersister = consoleOptionsFrontendPersister; @@ -71,6 +74,7 @@ this.rdpNativeProvider = rdpNativeProvider; this.vncNativeProvider = vncNativeProvider; this.noVncProvider = noVncProvider; + this.dynamicMessages = dynamicMessages; eventBus.addHandler(RestApiSessionAcquiredEvent.getType(), this); } @@ -106,6 +110,8 @@ return errorPopupManager; } else if (type == CurrentUserRole.class) { return currentUserRole; + } else if (type == DynamicMessages.class) { + return dynamicMessages; } throw new RuntimeException("UiCommon Resolver cannot resolve type: " + type); //$NON-NLS-1$ diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/DynamicMessages.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/BaseDynamicMessages.java similarity index 75% rename from frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/DynamicMessages.java rename to frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/BaseDynamicMessages.java index 3ae4817..f38e1bd 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/DynamicMessages.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/BaseDynamicMessages.java @@ -15,6 +15,7 @@ import java.util.Set; import org.ovirt.engine.ui.frontend.utils.BaseContextPathData; +import org.ovirt.engine.ui.uicommonweb.DynamicMessages; /** * Contains dynamic messages available to the application. @@ -22,7 +23,7 @@ * This class defines all supported message keys as well as corresponding value accessor methods. Subclasses should * register sensible fallback values for supported message keys. */ -public class DynamicMessages { +public class BaseDynamicMessages implements DynamicMessages { /** * This class defines keys used to look up messages from the {@code Dictionary}. @@ -76,11 +77,11 @@ */ private final Map<DynamicMessageKey, String> fallbackValues = new HashMap<DynamicMessageKey, String>(); - public DynamicMessages() { + public BaseDynamicMessages() { this(Dictionary.getDictionary(MESSAGES_DICTIONARY_NAME)); } - DynamicMessages(final Dictionary dictionary) { + BaseDynamicMessages(final Dictionary dictionary) { this.dictionary = dictionary; } @@ -195,117 +196,57 @@ return LocaleInfo.getCurrentLocale().getLocaleName(); } - /** - * Get the application title using the {@code Dictionary} in the host page. With a fall back to the standard GWT - * Constant. - * - * @return The application title string. - */ + @Override public final String applicationTitle() { return getString(DynamicMessageKey.APPLICATION_TITLE); } - /** - * Get the application version message using the {@code Dictionary} in the host page. With a fall back to the - * standard GWT Message. - * - * @param version - * The version string to use to replace the place holder in the message. - * @return The version about message - */ + @Override public final String ovirtVersionAbout(final String version) { return formatString(DynamicMessageKey.VERSION_ABOUT, version); } - /** - * Get the copy right notice using the {@code Dictionary} in the host page. With a fall back to the standard GWT - * Constant. - * - * @return The copy right notice string. - */ + @Override public final String copyRightNotice() { return getString(DynamicMessageKey.COPY_RIGHT_NOTICE); } - /** - * Get the feedback URL using the {@code Dictionary} in the host page. With a fall back to the standard GWT - * Constant. - * - * @return The feedback URL. - */ + @Override public final String feedbackUrl(final String version) { return formatString(DynamicMessageKey.FEEDBACK_URL, version); } - /** - * Get the feedback link label using the {@code Dictionary} in the host page. With a fall back to the standard GWT - * Constant. - * - * @return The feedback link label. - */ + @Override public final String feedbackLinkLabel() { return getString(DynamicMessageKey.FEEDBACK_LINK_LABEL); } - /** - * Get the feedback link tooltip using the {@code Dictionary} in the host page. With a fall back to the standard GWT - * Constant. - * - * @return The feedback link tooltip. - */ + @Override public final String feedbackLinkTooltip() { return getString(DynamicMessageKey.FEEDBACK_LINK_TOOLTIP); } - /** - * Get the guide URL using the {@code Dictionary} in the host page. Uses current locale (e.g. "en_US") - * for placeholder {0}, if it exists. With a fall back to the standard GWT Constant. - * - * @return The guide URL. - */ + @Override public final String guideUrl() { return formatString(DynamicMessageKey.GUIDE_URL, getCurrentLocaleAsString()); } - /** - * Get the guide link label using the {@code Dictionary} in the host page. With a fall back to the standard GWT - * Constant. - * - * @return The guide link label. - */ + @Override public final String guideLinkLabel() { return getString(DynamicMessageKey.GUIDE_LINK_LABEL); } - /** - * - * Get the console client resources link name using the {@code Dictionary} in the host page. With a fall back to - * the standard GWT Constant. - * - * @return The console client resources page name. - */ + @Override public final String consoleClientResources() { return getString(DynamicMessageKey.CONSOLE_CLIENT_RESOURCES); } - /** - * - * Get the client resources link name using the {@code Dictionary} in the host page. With a fall back to - * the standard GWT Constant. - * - * @return The client resources page name. - */ + @Override public final String clientResources() { return getString(DynamicMessageKey.CLIENT_RESOURCES); } - /** - * - * Get the console client resources page url using the {@code Dictionary} in the host page. With a fall back to - * the standard GWT Constant. - * - * @return The console client resources page url. - */ + @Override public final String consoleClientResourcesUrl() { String url = getString(DynamicMessageKey.CONSOLE_CLIENT_RESOURCES_URL); boolean isAbsolute = UriUtils.extractScheme(url) != null; @@ -315,23 +256,12 @@ : "/" + BaseContextPathData.getInstance().getRelativePath() + url; //$NON-NLS-1$ } - /** - * - * Get the vendor URL using the {@code Dictionary} in the host page. With a fall back to - * the standard GWT Constant. - * - * @return The vendor url. - */ + @Override public final String vendorUrl() { return getString(DynamicMessageKey.VENDOR_URL); } - /** - * Get the application documentation title using the {@code Dictionary} in the host page. With a fall back to the standard GWT - * Constant. - * - * @return The application documentation title string. - */ + @Override public final String applicationDocTitle() { return getString(DynamicMessageKey.DOC); } diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/ConsolePopupView.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/ConsolePopupView.java index 5c59481..14f8237 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/ConsolePopupView.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/ConsolePopupView.java @@ -6,7 +6,6 @@ import org.ovirt.engine.ui.common.idhandler.ElementIdHandler; import org.ovirt.engine.ui.common.idhandler.WithElementId; import org.ovirt.engine.ui.common.presenter.popup.ConsolePopupPresenterWidget; -import org.ovirt.engine.ui.common.utils.DynamicMessages; import org.ovirt.engine.ui.common.widget.Align; import org.ovirt.engine.ui.common.widget.WidgetWithInfo; import org.ovirt.engine.ui.common.widget.dialog.SimpleDialogPanel; @@ -15,6 +14,7 @@ import org.ovirt.engine.ui.common.widget.tooltip.WidgetTooltip; import org.ovirt.engine.ui.common.widget.uicommon.popup.console.EntityModelValueCheckBoxEditor; import org.ovirt.engine.ui.common.widget.uicommon.popup.console.EntityModelValueCheckbox.ValueCheckboxRenderer; +import org.ovirt.engine.ui.uicommonweb.DynamicMessages; import org.ovirt.engine.ui.uicommonweb.models.ConsolePopupModel; import org.ovirt.engine.ui.uicommonweb.models.ConsoleProtocol; import org.ovirt.engine.ui.uicommonweb.models.vms.ConsoleModel; diff --git a/frontend/webadmin/modules/gwt-common/src/test/java/org/ovirt/engine/ui/common/utils/DynamicMessagesTest.java b/frontend/webadmin/modules/gwt-common/src/test/java/org/ovirt/engine/ui/common/utils/DynamicMessagesTest.java index f3ae780..2dfcb85 100644 --- a/frontend/webadmin/modules/gwt-common/src/test/java/org/ovirt/engine/ui/common/utils/DynamicMessagesTest.java +++ b/frontend/webadmin/modules/gwt-common/src/test/java/org/ovirt/engine/ui/common/utils/DynamicMessagesTest.java @@ -11,16 +11,16 @@ import org.junit.Test; import org.junit.runner.RunWith; import org.mockito.runners.MockitoJUnitRunner; -import org.ovirt.engine.ui.common.utils.DynamicMessages.DynamicMessageKey; +import org.ovirt.engine.ui.common.utils.BaseDynamicMessages.DynamicMessageKey; @RunWith(MockitoJUnitRunner.class) public class DynamicMessagesTest { - DynamicMessages testMessages; + BaseDynamicMessages testMessages; @Before public void setUp() throws Exception { - testMessages = new DynamicMessages(null); + testMessages = new BaseDynamicMessages(null); } @Test diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/DynamicMessages.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/DynamicMessages.java new file mode 100644 index 0000000..4af09a5 --- /dev/null +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/DynamicMessages.java @@ -0,0 +1,115 @@ +package org.ovirt.engine.ui.uicommonweb; + +public interface DynamicMessages { + + /** + * Get the application title using the {@code Dictionary} in the host page. With a fall back to the standard GWT + * Constant. + * + * @return The application title string. + */ + String applicationTitle(); + + /** + * Get the application version message using the {@code Dictionary} in the host page. With a fall back to the + * standard GWT Message. + * + * @param version + * The version string to use to replace the place holder in the message. + * @return The version about message + */ + String ovirtVersionAbout(String version); + + /** + * Get the copy right notice using the {@code Dictionary} in the host page. With a fall back to the standard GWT + * Constant. + * + * @return The copy right notice string. + */ + String copyRightNotice(); + + /** + * Get the feedback URL using the {@code Dictionary} in the host page. With a fall back to the standard GWT + * Constant. + * + * @return The feedback URL. + */ + String feedbackUrl(String version); + + /** + * Get the feedback link label using the {@code Dictionary} in the host page. With a fall back to the standard GWT + * Constant. + * + * @return The feedback link label. + */ + String feedbackLinkLabel(); + + /** + * Get the feedback link tooltip using the {@code Dictionary} in the host page. With a fall back to the standard GWT + * Constant. + * + * @return The feedback link tooltip. + */ + String feedbackLinkTooltip(); + + /** + * Get the guide URL using the {@code Dictionary} in the host page. Uses current locale (e.g. "en_US") + * for placeholder {0}, if it exists. With a fall back to the standard GWT Constant. + * + * @return The guide URL. + */ + String guideUrl(); + + /** + * Get the guide link label using the {@code Dictionary} in the host page. With a fall back to the standard GWT + * Constant. + * + * @return The guide link label. + */ + String guideLinkLabel(); + + /** + * + * Get the console client resources page url using the {@code Dictionary} in the host page. With a fall back to + * the standard GWT Constant. + * + * @return The console client resources page url. + */ + String consoleClientResources(); + + /** + * + * Get the client resources link name using the {@code Dictionary} in the host page. With a fall back to + * the standard GWT Constant. + * + * @return The client resources page name. + */ + String clientResources(); + + /** + * + * Get the console client resources link name using the {@code Dictionary} in the host page. With a fall back to + * the standard GWT Constant. + * + * @return The console client resources page name. + */ + String consoleClientResourcesUrl(); + + /** + * + * Get the vendor URL using the {@code Dictionary} in the host page. With a fall back to + * the standard GWT Constant. + * + * @return The vendor url. + */ + String vendorUrl(); + + /** + * Get the application documentation title using the {@code Dictionary} in the host page. With a fall back to the standard GWT + * Constant. + * + * @return The application documentation title string. + */ + String applicationDocTitle(); + +} diff --git a/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationDynamicMessages.java b/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationDynamicMessages.java index 08599da..43a82b2 100644 --- a/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationDynamicMessages.java +++ b/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationDynamicMessages.java @@ -1,9 +1,9 @@ package org.ovirt.engine.ui.userportal; -import org.ovirt.engine.ui.common.utils.DynamicMessages; +import org.ovirt.engine.ui.common.utils.BaseDynamicMessages; import org.ovirt.engine.ui.userportal.gin.AssetProvider; -public class ApplicationDynamicMessages extends DynamicMessages { +public class ApplicationDynamicMessages extends BaseDynamicMessages { private final static ApplicationConstants constants = AssetProvider.getConstants(); diff --git a/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicDetailsPresenterWidget.java b/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicDetailsPresenterWidget.java index cc47398..24c30b5 100644 --- a/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicDetailsPresenterWidget.java +++ b/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicDetailsPresenterWidget.java @@ -6,8 +6,8 @@ import org.ovirt.engine.core.common.businessentities.storage.DiskImage; import org.ovirt.engine.ui.common.presenter.popup.ConsoleModelChangedEvent; import org.ovirt.engine.ui.common.presenter.popup.ConsoleModelChangedEvent.ConsoleModelChangedHandler; -import org.ovirt.engine.ui.common.utils.DynamicMessages; import org.ovirt.engine.ui.common.widget.HasEditorDriver; +import org.ovirt.engine.ui.uicommonweb.DynamicMessages; import org.ovirt.engine.ui.uicommonweb.ErrorPopupManager; import org.ovirt.engine.ui.uicommonweb.models.ConsoleProtocol; import org.ovirt.engine.ui.uicommonweb.models.VmConsoles; diff --git a/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicDetailsView.java b/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicDetailsView.java index 97d222e..a6feb33 100644 --- a/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicDetailsView.java +++ b/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicDetailsView.java @@ -3,8 +3,8 @@ import org.ovirt.engine.core.common.businessentities.storage.DiskImage; import org.ovirt.engine.ui.common.idhandler.ElementIdHandler; import org.ovirt.engine.ui.common.idhandler.WithElementId; -import org.ovirt.engine.ui.common.utils.DynamicMessages; import org.ovirt.engine.ui.common.view.AbstractView; +import org.ovirt.engine.ui.uicommonweb.DynamicMessages; import org.ovirt.engine.ui.uicommonweb.dataprovider.AsyncDataProvider; import org.ovirt.engine.ui.uicommonweb.models.userportal.UserPortalBasicListModel; import org.ovirt.engine.ui.userportal.section.main.presenter.tab.basic.MainTabBasicDetailsPresenterWidget; diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationDynamicMessages.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationDynamicMessages.java index ef577a6..ff98951 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationDynamicMessages.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationDynamicMessages.java @@ -1,9 +1,9 @@ package org.ovirt.engine.ui.webadmin; -import org.ovirt.engine.ui.common.utils.DynamicMessages; +import org.ovirt.engine.ui.common.utils.BaseDynamicMessages; import org.ovirt.engine.ui.webadmin.gin.AssetProvider; -public class ApplicationDynamicMessages extends DynamicMessages { +public class ApplicationDynamicMessages extends BaseDynamicMessages { private final static ApplicationConstants constants = AssetProvider.getConstants(); -- To view, visit https://gerrit.ovirt.org/41947 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If2430ac25d91b31be05b224d2c860f0905341279 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
