Moran Goldboim has posted comments on this change.
Change subject: packaging: [DO NOT MERGE] Handling active tasks during upgrade
......................................................................
Patch Set 5: (3 inline comments)
....................................................
File packaging/fedora/setup/engine-upgrade.py
Line 829: while (len(runningTasks) > 0 or len(compensations) > 0 )
and \
Line 830: count < MAINTENANCE_TASKS_CYCLES:
Line 831: logging.debug("Still waiting for tasks and
compensations to be cleared. %s more cycles to wait" %
(MAINTENANCE_TASKS_CYCLES - count))
Line 832: time.sleep(MAINTENANCE_TASKS_WAIT_PERIOD )
Line 833:
+1, but let's take longer intervals (3 minutes) so user won't be prompted
repetitiously
Line 834: runningTasks = getRunningTasks(dbName)
Line 835: count += 1
Line 836:
Line 837: # Check if there are still running tasks
Line 836:
Line 837: # Check if there are still running tasks
Line 838: if len(runningTasks) > 0 or len(compensations) > 0:
Line 839: # There are still tasks running, so ask user what to
do
Line 840: RUNNING_TASKS_MSG = MSG_TASKS_COMPENSATIONS %
(runningTasks, compensations)
thought it was agreed not to force delete tasks, which can lead to data
corruption.
Line 841: raise Exception(MSG_TASKS_STILL_RUNNING %
RUNNING_TASKS_MSG)
Line 842:
Line 843:
Line 844: except:
Line 839: # There are still tasks running, so ask user what to
do
Line 840: RUNNING_TASKS_MSG = MSG_TASKS_COMPENSATIONS %
(runningTasks, compensations)
Line 841: raise Exception(MSG_TASKS_STILL_RUNNING %
RUNNING_TASKS_MSG)
Line 842:
Line 843:
yes
Line 844: except:
Line 845: raise
Line 846:
Line 847: finally:
--
To view, visit http://gerrit.ovirt.org/8740
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I90abb3d1e6ad0ac5557485e40064e811fc87f491
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
