Yair Zaslavsky has posted comments on this change.
Change subject: core: adding unlock_entity.sh script(#868638)
......................................................................
Patch Set 11: (1 inline comment)
....................................................
File backend/manager/dbscripts/dbfunctions.sh
Line 383: #adds a record to audit_log in case of calling unlock_entity
Line 384: log_unlock_entity() {
Line 385: local object_type=${1}
Line 386: local id=${2}
Line 387: msg="User ${USERNAME} run unlock_entity script on ${object_type}
${id}"
As I stated in the email I sent -
Will we want to work with different postgres users? Won't it be the same user?
When you state "User" - one might assume after looking at events in the system
that he has a user in the system called postgres, which is wrong.
Line 388: CMD="insert into
audit_log(log_time,log_type_name,log_type,severity,message)
Line 389: values(now(), 'USER_RUN_UNLOCK_ENTITY_SCRIPT', 2024, 10,
'${msg}')"
Line 390: execute_command "${CMD}" "${DATABASE}" "${SERVERNAME}" "${PORT}"
Line 391: }
--
To view, visit http://gerrit.ovirt.org/8688
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f1712fb945933d92ee9a6b97bc71d4ba3a01597
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
