Oved Ourfali has submitted this change and it was merged. Change subject: engine: Inject dependencies to FutureVdsCommand ......................................................................
engine: Inject dependencies to FutureVdsCommand Without injecting the dependencies, auditing an event to log would fail with NPE when trying to obtain the AuditLogDirector. In addition, the c'tor of VdsBrokerCommand should have taken care of initializing the 'vds' member of it. Change-Id: I975a2752c21d60dacb452714d0910dc658897a4a Signed-off-by: Moti Asayag <[email protected]> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerCommand.java 2 files changed, 14 insertions(+), 9 deletions(-) Approvals: Marcin Mirecki: Looks good to me, but someone else must approve Jenkins CI: Verified; Looks good to me, but someone else must approve Moti Asayag: Verified Oved Ourfali: Looks good to me, approved Yevgeny Zaspitsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/42026 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I975a2752c21d60dacb452714d0910dc658897a4a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
