Allon Mureinik has posted comments on this change.
Change subject: core, restapi: Convert NFS version to enum
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(4 inline comments)
....................................................
File
backend/manager/dbscripts/upgrade/03_01_1470_change_nfs_version_to_string.sql
Line 1: SELECT
fn_db_change_column_type('storage_server_connections','nfs_version','smallint','varchar(4)');
if it can no longer be null (according to the commit message), it should be
reflected in the database.
I'd do the following:
1. Change the type to varchar(4), like you did.
2. Update the null values to AUTO:
UPDATE storage_server_connections SET nfs_version='auto' WHERE nfs_version IS
NULL;
3. change the column to not nullable:
SELECT
fn_db_change_column_type('storage_server_connections','nfs_version','varchar(4)'
,'varchar(4) not null');
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NfsVersion.java
Line 9: V3("3"),
Line 10: V4("4");
Line 11:
Line 12: private final String version;
Line 13: private static java.util.HashMap<String, NfsVersion> mappings =
should be final.
Also, replace java.util.HashMap with Map.
Line 14: new HashMap<String, NfsVersion>();
Line 15:
Line 16: static {
Line 17: for (NfsVersion nfsVersion : values()) {
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/NfsVersion.java
Line 1: package org.ovirt.engine.core.common.businessentities;
This should be in org.ovirt.engine.api.model
Line 2:
Line 3: import java.util.HashMap;
Line 4:
Line 5: public enum NfsVersion {
Line 9: V3("3"),
Line 10: V4("4");
Line 11:
Line 12: private final String version;
Line 13: private static java.util.HashMap<String, NfsVersion> mappings =
s/java.util.HashMap/Map/
Line 14: new HashMap<String, NfsVersion>();
Line 15:
Line 16: static {
Line 17: for (NfsVersion nfsVersion : values()) {
--
To view, visit http://gerrit.ovirt.org/8797
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I09d82db7c0ec92135cae8935f013487e97b8f357
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Greg Padgett <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
