Liron Aravot has posted comments on this change.
Change subject: core: NPE while adding lun disks (#869596)
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
Line 332:
Line 333: private void createDiskBasedOnImage() {
Line 334: if(!getParameters().getDiskInfo().isWipeAfterDeleteSet()) {
Line 335: StorageType storageType =
getStorageDomain().getstorage_type();
Line 336:
getParameters().getDiskInfo().setWipeAfterDelete(WipeAfterDeleteUtils.getDefaultWipeAfterDeleteFlag(storageType));
sorry, didn't understand the question. parameters are set with the parent
parameters, so it should be fine.
Line 337: }
Line 338: // create from blank template, create new vm snapshot id
Line 339: AddImageFromScratchParameters parameters =
Line 340: new AddImageFromScratchParameters(Guid.Empty,
--
To view, visit http://gerrit.ovirt.org/8821
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id754bdd7b49ff0dcc80b060f5900f8e3ea313637
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
