Mike Kolesnik has posted comments on this change.
Change subject: core: PairQueryable Class
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/PairQueryable.java
Line 7: */
Line 8: public class PairQueryable<T, K> extends IVdcQueryable {
Line 9: private static final long serialVersionUID = -8894728003078425184L;
Line 10:
Line 11: private Pair<T, K> pair = new Pair<T, K>();
Redundant initialization if you lazy init it anyway
Line 12:
Line 13: public PairQueryable() {
Line 14: }
Line 15:
Line 16: public PairQueryable(T first, K second) {
Line 17: pair = new Pair<T, K>(first, second);
Line 18: }
Line 19:
Line 20: public Pair<T, K> getPair() {
Why not have this method private?
Line 21: return pair == null ? new Pair<T, K>(null, null) : pair;
Line 22: }
Line 23:
Line 24: public void setPair(Pair<T, K> pair) {
Line 20: public Pair<T, K> getPair() {
Line 21: return pair == null ? new Pair<T, K>(null, null) : pair;
Line 22: }
Line 23:
Line 24: public void setPair(Pair<T, K> pair) {
Is this method mandatory?
Line 25: this.pair = pair;
Line 26: }
Line 27:
Line 28: public void setFirst(T value) {
--
To view, visit http://gerrit.ovirt.org/8833
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic26f8c18245eb187a6ee20dcb2b9b9c03c3992bf
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
