Deepak C Shetty has posted comments on this change. Change subject: core: WIP: Introduce AddGlusterFsStorageDomainCommand. ......................................................................
Patch Set 1: Few high level points that I have in mind... 1) IIUC this doesn't cover the case where vfsType is autofilled to 'glusterfs' (and the field greyed/disabled) when user selects GLUSTERFS_DOMAIN in the GUI. It would be good to have that from usability perspective. 2) IIRC, there is a option in OE to enable a gluster volume for virtualization use ( sets some gluster specific options to ensure its works well when used as a storage domain). As part of user creating GLUSTERFS_DOMAIN, it would be good to check if the gluster volume (as part of the 'spec') is enabled for virt use, and if not, call the appropriate Gluster OE API to enable the gluster volume for virt use, before using it as storage domain. Not sure how this plays when OE is in virt only, gluster only and virt_+ gluster modes. 3) Another enhancement (maybe future if not now) could be to list the available gluster volumes known to oVirt when user selects GLUSTERFS_DOMAIN as the DC type as part of new storage domain UI flow. User can then select the gluster volume he/she created and the 'spec' will be formed based on that. This ensure better usability and might be useful when OE is in virt + gluster mode. -- To view, visit http://gerrit.ovirt.org/8837 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia62dd8732dee94a8478897845e1166ef2b1ef301 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <[email protected]> Gerrit-Reviewer: Deepak C Shetty <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
