Allon Mureinik has posted comments on this change.
Change subject: engine: Forbid adding an existing SAN Export Storage Domain
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(2 inline comments)
+1 on the backend side.
See some minor text issues inline - please fix when you rebase this patch.
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 404: ERROR_CANNOT_EXTEND_CONNECTION_FAILED=Cannot extend Storage Domain.
Storage device ${lun} is unreachable on ${hostName}.
Line 405: ERROR_CANNOT_CHANGE_STORAGE_DOMAIN_FIELDS=Cannot ${action} ${type}.
Only Storage Domain name is updateable.
Line 406:
ERROR_CANNOT_UPDATE_STORAGE_POOL_COMPATIBILITY_VERSION_BIGGER_THAN_CLUSTERS=Cannot
update Data Center compatibility version to a value that is greater than its
Cluster's version. The following clusters should be upgraded ${ClustersList}.
Line 407:
ERROR_CANNOT_ADD_EXISTING_STORAGE_DOMAIN_CONNECTION_DATA_ILLEGAL=Cannot import
Storage Domain. Internal Error: The connection data is illegal.
Line 408: ERROR_CANNOT_ADD_DEPRECATED_EXISTING_SAN_EXPORT_STORAGE_DOMAIN=Cannot
import SAN Export Storage Domain as it is deprecated.
consider replacing deprecated with "no longer supported"
Line 409: ERROR_CANNOT_ADD_EXISTING_STORAGE_DOMAIN_LUNS_PROBLEM=Cannot import
Storage Domain. Not all LUNs connected to Storage Domain.
Line 410: NETWORK_MAC_ADDRESS_IN_USE=MAC Address is already in use.
Line 411: NETWORK_INVALID_MAC_ADDRESS=The specified MAC Address cannot be
set.\n\
Line 412: -Please check MAC Address validity.
....................................................
Commit Message
Line 7: engine: Forbid adding an existing SAN Export Storage Domain
Line 8:
Line 9: - Forbid adding an existing SAN Export Storage Domain as this type
Line 10: of domain is deprecated in the AddExistingSANStorageDomain command.
Line 11: - Remove the SNA Export Storage Domain options from the storage type in
s/SNA/SAN/
Line 12: the 'Import Domain' dialog.
Line 13:
Line 14: Bug-Url: https://bugzilla.redhat.com/865506
Line 15: Change-Id: I35b46ff1a507732e38b8979db067a9c52b927714
--
To view, visit http://gerrit.ovirt.org/8838
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I35b46ff1a507732e38b8979db067a9c52b927714
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Asaf Shakarchi <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
