Yair Zaslavsky has posted comments on this change. Change subject: core: Quota refactor - QuotaManager step 2 ......................................................................
Patch Set 5: (1 inline comment) Just one question .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java Line 936: // cache in direct quota map Line 937: Quota quota = getQuotaDAO().getById(quotaId); Line 938: directQuotaMap.put(quotaId, quota); Line 939: // cache in storage-pool->quota map Line 940: storagePoolQuotaMap.putIfAbsent(quota.getStoragePoolId(), new HashMap<Guid, Quota>()); I hope you realize the two lines are not atomic. Just want to make sure - if you're fine with that - cool. Line 941: storagePoolQuotaMap.get(quota.getStoragePoolId()).put(quotaId, quota); Line 942: } Line 943: return directQuotaMap.get(quotaId); Line 944: } -- To view, visit http://gerrit.ovirt.org/8777 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15314d6269d1f5f43de17c36a6ae91ba874c8a58 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <oma...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: ofri masad <oma...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
