Michael Pasternak has posted comments on this change.
Change subject: restapi: Default VM display type overrides current VM display
type in REST API(#864961)
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java
Line 939: }
Line 940: return pin;
Line 941: }
Line 942:
Line 943: private static boolean
isValidSessionState(org.ovirt.engine.core.common.businessentities.VM entity) {
i would change this method name to something more informative
Line 944: return entity.getstatus() == VMStatus.Up ||
Line 945: entity.getstatus() == VMStatus.PoweringUp ||
Line 946: entity.getstatus() == VMStatus.WaitForLaunch ||
Line 947: entity.getstatus() == VMStatus.PoweredDown ||
--
To view, visit http://gerrit.ovirt.org/8822
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie838e8096909865647bed2d79e9571059f6095aa
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
