Michael Pasternak has posted comments on this change.
Change subject: restapi: <placement_policy> should accept <host> by name
(#757115)
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java
Line 100: // resolve the host's ID, because it will be needed
down the line
Line 101: if (vm.isSetPlacementPolicy() &&
vm.getPlacementPolicy().isSetHost()
Line 102: &&
vm.getPlacementPolicy().getHost().isSetName()
Line 103: &&
!vm.getPlacementPolicy().getHost().isSetId()) {
Line 104:
staticVm.setdedicated_vm_for_vds(createGuidFromString(getHostId(vm.getPlacementPolicy().getHost().getName())));
please use asGuid() instead
Line 105: }
Line 106: } else {
Line 107: vm.setPlacementPolicy(null);
Line 108: }
--
To view, visit http://gerrit.ovirt.org/8819
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I09c9ad52db15e18813632598aca701e2b18af3d6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
